fix(sdk-trace-base): don't load envs top level #5233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving? / Short description of the changes
Right now
@opentelemetry/sdk-trace-base
loadsOTEL_*
env vars when it is loaded, regardless of ifloadDefaultConfig
is ever called. In runtimes with a permission model like Deno, this may cause a bunch of permission prompts right on startup. This PR changes the env vars to all be loaded whenloadDefaultConfig
is called.Interestingly, previously only
buildSamplerFromEnv
used the "global" env vars. For all other options the env vars are re-read on every call toloadDefaultConfig
.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have tested locally that Deno does not prompt for env vars on startup anymore when
@opentelemetry/sdk-trace-base
is loaded.Checklist:
Unit tests have been addedN/ADocumentation has been updatedN/A