refactor(sdk-trace-base): remove _registeredSpanProcessors from BasicTracerProvider
#5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
changed the title
_registeredSpanProcessors from BasicTracerProvider_registeredSpanProcessors from BasicTracerProvider
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5177 +/- ##
==========================================
- Coverage 93.15% 93.14% -0.02%
==========================================
Files 315 315
Lines 8113 8106 -7
Branches 1633 1633
==========================================
- Hits 7558 7550 -8
- Misses 555 556 +1
|
david-luna
commented
Nov 19, 2024
| @@ -97,10 +97,8 @@ export class SpanImpl implements Span { | |||
| private readonly _startTimeProvided: boolean; | |||
|
|
|||
| /** | |||
| * Constructs a new Span instance. | |||
| * | |||
| * @deprecated calling Span constructor directly is not supported. Please use tracer.startSpan. | |||
There was a problem hiding this comment.
note to reviewer: this is a leftover from #5048. The class is now internal and used in Tracer
david-luna
commented
Nov 19, 2024
| } | ||
|
|
||
| this.activeSpanProcessor = new MultiSpanProcessor(spanProcessors); |
There was a problem hiding this comment.
note to reviewer: forceFlush method was only iterating over the _registeredSpanProcessors. So when using the default exporter and processor (the else case) the BatchSpanProcessor.forceFlush method was never called. I've added a test for it
david-luna
commented
Nov 19, 2024
| @@ -779,6 +834,29 @@ describe('BasicTracerProvider', () => { | |||
| }); | |||
|
|
|||
| describe('.forceFlush()', () => { | |||
| it('should call forceFlush with the default processor', done => { | |||
There was a problem hiding this comment.
note for reviewer: this is the test to check that with exporter/processor defined from env the forceFlush method is called.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
After merging #5152 it is not necessary to have
_registeredSpanProcessorsprivate property to modify at runtime. This PR does remove the property and adapts the tests.Fixes #5136
Short description of the changes
_registeredSpanProcessorsfromBasicTracerProviderforceFlushworks in all situations.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: