fix(jaeger-remote-sampler): Catch errors retrieving remote config (#4976

)
open-telemetry · Sep 4, 2024 · a3983fa · a3983fa
1 parent 9d474e3
commit a3983fa
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md
@@ -11,6 +11,8 @@ All notable changes to experimental packages in this project will be documented
 
 ### :bug: (Bug Fix)
 
+* fix(sampler-jaeger-remote): fixes an issue where package could emit unhandled promise rejections @Just-Sieb
+
 ### :books: (Refine Doc)
 
 ### :house: (Internal)

diff --git a/experimental/packages/sampler-jaeger-remote/src/JaegerRemoteSampler.ts b/experimental/packages/sampler-jaeger-remote/src/JaegerRemoteSampler.ts
@@ -58,6 +58,8 @@ export class JaegerRemoteSampler implements Sampler {
       this._syncingConfig = true;
       try {
         await this.getAndUpdateSampler();
+      } catch (err) {
+        diag.warn('Could not update sampler', err);
       } finally {
         this._syncingConfig = false;
       }

diff --git a/experimental/packages/sampler-jaeger-remote/test/JaegerRemoteSampler.test.ts b/experimental/packages/sampler-jaeger-remote/test/JaegerRemoteSampler.test.ts
@@ -80,13 +80,28 @@ describe('JaegerRemoteSampler', () => {
       );
       new JaegerRemoteSampler({
         endpoint,
-        serviceName,
         poolingInterval,
+        serviceName,
         initialSampler: alwaysOnSampler,
       });
       await clock.tickAsync(poolingInterval * 2);
       sinon.assert.callCount(getAndUpdateSamplerStub, 1);
     });
+
+    it('Doesnt throw unhandled promise rejection when failing to get remote config', async () => {
+      getAndUpdateSamplerStub.rejects();
+      const unhandledRejectionListener = sinon.fake();
+      process.once('unhandledRejection', unhandledRejectionListener);
+      new JaegerRemoteSampler({
+        endpoint,
+        serviceName,
+        poolingInterval,
+        initialSampler: alwaysOnSampler,
+      });
+      await clock.tickAsync(poolingInterval * 2);
+      sinon.assert.callCount(getAndUpdateSamplerStub, 2);
+      sinon.assert.callCount(unhandledRejectionListener, 0);
+    });
   });
 
   describe('shouldSample', () => {