fix(sdk-metrics): Add missing catch and handle error in promise of `P…

…eriodicExportingMetricReader` (#5006)
open-telemetry · Sep 24, 2024 · 5627d84 · 5627d84
1 parent 4574bf5
commit 5627d84
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
 ### :bug: (Bug Fix)
 
 * fix(sdk-trace-base): avoid keeping non-string `status.message` on `Span#setStatus()` [#4999](https://github.com/open-telemetry/opentelemetry-js/pull/4999) @pichlermarc
+* fix(sdk-metrics): Add missing catch and handle error in promise of `PeriodicExportingMetricReader` [#5006](https://github.com/open-telemetry/opentelemetry-js/pull/5006) @jj22ee
 
 ### :books: (Refine Doc)
 

diff --git a/packages/sdk-metrics/src/export/PeriodicExportingMetricReader.ts b/packages/sdk-metrics/src/export/PeriodicExportingMetricReader.ts
@@ -142,7 +142,8 @@ export class PeriodicExportingMetricReader extends MetricReader {
         .waitForAsyncAttributes?.()
         .then(doExport, err =>
           diag.debug('Error while resolving async portion of resource: ', err)
-        );
+        )
+        .catch(globalErrorHandler);
     } else {
       await doExport();
     }