Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Migrate away from deprecated addSpanProcessor in examples #2655

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

chancancode
Copy link
Contributor

This migrates from the deprecated addSpanProcessor method to the constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates everything in the examples folder and there are no changes to the published packages.

Ref #2645 (cc @pichlermarc)

This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates everything in the `examples` folder and there
are no changes to the published packages.

Ref open-telemetry#2645
@chancancode chancancode requested a review from a team as a code owner January 16, 2025 23:50
@chancancode chancancode changed the title fix(examples): Migrate away from deprecated addSpanProcessor SDK2 fix(examples): Migrate away from deprecated addSpanProcessor in examples Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (b0f1999) to head (b7bdadf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2655   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         172      172           
  Lines        8137     8137           
  Branches     1649     1649           
=======================================
  Hits         7402     7402           
  Misses        735      735           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you :)

@chancancode
Copy link
Contributor Author

@pichlermarc updated the branch from the UI here, let me know if you need a proper rebase

@pichlermarc pichlermarc merged commit 46accdc into open-telemetry:main Jan 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants