Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-runtime-node): use the correct unit for eventloop.utilization #2631

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Jan 8, 2025

Which problem is this PR solving?

Short description of the changes

  • Unit of the metric eventloop.utilization was wrongly using s, instead of the unit 1, as defined its semantic convention

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (4cfcc59) to head (320f48b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2631   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         169      169           
  Lines        8059     8059           
  Branches     1645     1645           
=======================================
  Hits         7317     7317           
  Misses        742      742           
Files with missing lines Coverage Δ
...-node/src/metrics/eventLoopUtilizationCollector.ts 88.23% <ø> (ø)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you 🙂

@pichlermarc pichlermarc merged commit 3350583 into open-telemetry:main Jan 9, 2025
10 checks passed
@dyladan dyladan mentioned this pull request Jan 9, 2025
@maryliag maryliag deleted the fix-runtime-unit branch January 9, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodejs.eventloop.utilization under instrumentation-runtime-node is a percentage, not a duration
2 participants