Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-hapi): fix this binding for plugin register method #2625

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Jan 7, 2025

Which problem is this PR solving?

#2624

Short description of the changes

Correctly bind this to plugin's register method.

@seemk seemk requested a review from a team as a code owner January 7, 2025 11:37
@github-actions github-actions bot added pkg:instrumentation-hapi pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (3bab134) to head (be1b587).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2625   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         169      169           
  Lines        8055     8056    +1     
  Branches     1643     1643           
=======================================
+ Hits         7313     7314    +1     
  Misses        742      742           
Files with missing lines Coverage Δ
...emetry-instrumentation-hapi/src/instrumentation.ts 99.31% <100.00%> (+<0.01%) ⬆️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pichlermarc pichlermarc merged commit f6ded2e into open-telemetry:main Jan 7, 2025
11 checks passed
@dyladan dyladan mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:instrumentation-hapi pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants