Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(propagator-aws-xray): correctly propagate over grpc #2604

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

dweitzman-codaio
Copy link
Contributor

Similar to open-telemetry/opentelemetry-js#2285 for the b3 propagator

Which problem is this PR solving?

Fixes open-telemetry/opentelemetry-js#4830

Short description of the changes

@dweitzman-codaio dweitzman-codaio requested a review from a team as a code owner December 13, 2024 19:59
Copy link

linux-foundation-easycla bot commented Dec 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dweitzman-codaio / name: David Weitzman (35dbd46, ea0e07f)
  • ✅ login: pichlermarc / name: Marc Pichler (24bd52f)

@github-actions github-actions bot added pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. pkg:propagator-aws-xray labels Dec 13, 2024
@github-actions github-actions bot requested a review from jj22ee December 13, 2024 19:59
@dweitzman-codaio dweitzman-codaio changed the title Fix grpc propagation with XRay propagator fix(propagator-aws-xray): correctly propagate over grpc Dec 13, 2024
@dweitzman-codaio
Copy link
Contributor Author

cc @dyladan since open-telemetry/opentelemetry-js#4830 is currently assigned to you

This comment was marked as outdated.

@pichlermarc pichlermarc removed pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. pkg-status:unmaintained:autoclose-scheduled labels Dec 16, 2024
@pichlermarc
Copy link
Member

Note: "unmaintained" label was applied incorrectly, @jj22ee is the owner.
I opened #2606 to address this.

@jj22ee
Copy link
Contributor

jj22ee commented Dec 17, 2024

LGTM. Can you add a test case for this fix, similar to the B3 one?

@dweitzman-codaio
Copy link
Contributor Author

LGTM. Can you add a test case for this fix, similar to the B3 one?

Done

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (12ee8db) to head (24bd52f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2604   +/-   ##
=======================================
  Coverage   90.78%   90.79%           
=======================================
  Files         169      169           
  Lines        8056     8059    +3     
  Branches     1643     1645    +2     
=======================================
+ Hits         7314     7317    +3     
  Misses        742      742           
Files with missing lines Coverage Δ
...ators/propagator-aws-xray/src/AWSXRayPropagator.ts 100.00% <100.00%> (ø)

@pichlermarc pichlermarc merged commit 4cfcc59 into open-telemetry:main Jan 9, 2025
23 checks passed
@dyladan dyladan mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propagator-aws-xray broken with GRPC?
3 participants