Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples/express): small refactor of imports #2562

Merged

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Nov 27, 2024

Minor refactor to clean up imports from the api pkg.
Remove the DiagConsoleLogger for now. There isn't any useful diag log output
for this example, and configuring it just adds some noise.

Minor refactor to clean up imports from the api pkg.
Remove the DiagConsoleLogger for now. There isn't any useful diag log output
for this example, and configuring it just adds some noise.
@trentm trentm self-assigned this Nov 27, 2024
@trentm trentm requested a review from a team as a code owner November 27, 2024 19:33
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (d7773a2) to head (8c19655).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2562      +/-   ##
==========================================
+ Coverage   90.75%   90.80%   +0.04%     
==========================================
  Files         169      169              
  Lines        8018     8018              
  Branches     1632     1632              
==========================================
+ Hits         7277     7281       +4     
+ Misses        741      737       -4     

see 1 file with indirect coverage changes

@trentm trentm merged commit 4aba201 into open-telemetry:main Nov 27, 2024
20 checks passed
@trentm trentm deleted the tm-small-express-example-refactor branch November 27, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants