Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-instrumentations-node): enable runtime-node #2524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romancepenguin
Copy link

Which problem is this PR solving?

Short description of the changes

  • This PR adds @opentelemetry/instrumentation-runtime-node to the @opentelemetry/auto-instrumentations-node meta package

@romancepenguin romancepenguin requested a review from a team as a code owner November 11, 2024 09:47
Copy link

linux-foundation-easycla bot commented Nov 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: romancepenguin / name: leejaekyu (d013655)

@romancepenguin romancepenguin force-pushed the runtime-node-auto-instrumentation branch from 441d85f to d013655 Compare November 11, 2024 11:37
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (5eb61d8) to head (d013655).
Report is 47 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2524   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8019    +1     
  Branches     1632     1632           
=======================================
+ Hits         7277     7278    +1     
  Misses        741      741           
Files with missing lines Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.24% <100.00%> (+0.01%) ⬆️

@ElfoLiNk
Copy link

Hi, would be good to have this merged and released.
Thank you

@pichlermarc
Copy link
Member

This PR needs approval from the owner of the instrumentation, cc @d4nyll - having it in the auto-instrumentation package and enabled by default will likely mean more users, which means often means that additional maintenance effort is required.

@d4nyll
Copy link
Contributor

d4nyll commented Jan 15, 2025

@pichlermarc Happy to handle any additional maintenance work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants