Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-undici): Fix RequestType #2503

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mtreinik
Copy link
Contributor

  • Previously RequestType was accidentally assigned with UndiciResponse while the correct type is UndiciRequest

Which problem is this PR solving?

  • ResponseHookFunction<RequestType> had incorrect type

Short description of the changes

  • Use correct type UndiciRequest for RequestType instead of wrong type UndiciResponse

@mtreinik mtreinik requested a review from a team as a code owner October 24, 2024 20:07
Copy link

linux-foundation-easycla bot commented Oct 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mtreinik / name: Mikko Reinikainen (c865f1f)

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (7633cae) to head (c865f1f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2503   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         159      159           
  Lines        7853     7853           
  Branches     1622     1622           
=======================================
  Hits         7135     7135           
  Misses        718      718           

- Previously RequestType was accidentally assigned with UndiciResponse while the correct type is UndiciRequest
@david-luna david-luna merged commit 9a20e15 into open-telemetry:main Oct 28, 2024
23 checks passed
@dyladan dyladan mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants