-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up some deps #2499
Conversation
- Use range deps for `@opentelemetry/*` deps (with some exceptions for /api and /semantic-conventions). This allows scripts/update-otel-deps.js to be able to do its thing. - "propagators/propagator-aws-xray/" only needed `@opentelemetry/core` for tests
@@ -57,6 +57,7 @@ | |||
}, | |||
"devDependencies": { | |||
"@opentelemetry/api": ">=1.0.0 <1.10.0", | |||
"@opentelemetry/core": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer note: This had been ^1.0.0
before it was moved to the core repo and then back here. The only usage is for import { TraceState } from '@opentelemetry/core';
in tests.
…urrent latest version ^1.26.0
@pichlermarc @JamieDanielson This is the change I needed before doing the "scripts/update-otel-deps.js" PR -- as discussed in the SIG today. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2499 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 159 159
Lines 7851 7851
Branches 1621 1621
=======================================
Hits 7133 7133
Misses 718 718 |
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 👍
@opentelemetry/*
deps (with some exceptions for/api and /semantic-conventions). This allows
scripts/update-otel-deps.js to be able to do its thing.
@opentelemetry/core
for tests