fix(instrumentation-mysql): fix test for mysql2 v3 (#2168)

[tpraxl]

Which problem is this PR solving?

Fixes #2168 - migrate to v3 in tests

Short description of the changes

Update mysql2 dependency to latest version (@3.11.3) and fix tests. Problems during npm run compile were fixed by removing an unsafe and incorrect typecast.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tpraxl / name: Thomas Praxl (11f6a52, 91adced, 43da503, 342410c, 96ad247)
• ✅ login: blumamir / name: Amir Blum (d8daccc)
• ✅ login: pichlermarc / name: Marc Pichler (10c0288)

[tpraxl]

Hold on. I was mislead. While the mysql2 tests do compile now and they signaled success during npm test, all of them were actually skipped (see process.env.RUN_MYSQL_TESTS_LOCAL and process.env.RUN_MYSQL_TESTS).

I really think you should generally separate skipped tests from succeeded tests in the output.

I only noticed that, because I actually want to fix #1511 and started to work on that.

Let's see if I can fix the tests when they are not skipped. Might take a while, depending on the time I can spare. In the meantime: Should I close this PR or do you want to keep it open?

[tpraxl]

The tests succeeded (except for fastify and mongoose), once I figured out that I need to export RUN_MYSQL_TESTS="true" in order for otherwise skipped tests not to signal that they succeeded, AND have a docker container running with exact these arguments:

podman run --rm -d --name otel-mysql -p 33306:3306 -e MYSQL_ROOT_PASSWORD=rootpw -e MYSQL_DATABASE=test_db -e MYSQL_USER=otel -e MYSQL_PASSWORD=secret mysql:5.7 --log_output=TABLE --general_log=ON

(Where general_log=ON is necessary for some tests that failed before)

You should mention that somewhere in the README under "How to run tests the right way".

This PR is now ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (a926f53) to head (d8daccc).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         159      159           
  Lines        7831     7831           
  Branches     1610     1610           
=======================================
  Hits         7113     7113           
  Misses        718      718           

[david-luna]

LGTM. Thanks for contributing to OpenTelemetry :)

@haddasbronfman any feedback?

[github-actions]

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

[tpraxl]

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. Are you familiar with this package? Consider becoming a component owner.

Uh.. can anyone explain what happened? How likely is this PR being closed in 14 days?

[maryliag]

@tpraxl this message is automatic for all unmaintained packages, to make it clear we won't accept new features unless there is a new code owner for it, but we're still accepting fixes, so we would be able to merge your PR, is just a matter of getting the approval and a maintainer merging it.
In case it doesn't happen and it gets closed 14 days, you can just re-open and poke someone with the permissions to merge this for you :)

[blumamir]

Thanks @tpraxl !

Please fix the conflicts and then I'll merge