Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detector-aws): add DetectorSync implementation for EKS detector #2333

Closed

chore(detector-aws): fix lint issues

acf8650
Select commit
Loading
Failed to load commit list.
Closed

feat(detector-aws): add DetectorSync implementation for EKS detector #2333

chore(detector-aws): fix lint issues
acf8650
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 1, 2024 in 0s

90.42% (-0.56%) compared to dfb2dff

View this Pull Request on Codecov

90.42% (-0.56%) compared to dfb2dff

Details

Codecov Report

Attention: Patch coverage is 91.95402% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.42%. Comparing base (dfb2dff) to head (acf8650).
Report is 199 commits behind head on main.

Files Patch % Lines
...e-detector-aws/src/detectors/AwsEksDetectorSync.ts 91.46% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2333      +/-   ##
==========================================
- Coverage   90.97%   90.42%   -0.56%     
==========================================
  Files         146      150       +4     
  Lines        7492     7371     -121     
  Branches     1502     1527      +25     
==========================================
- Hits         6816     6665     -151     
- Misses        676      706      +30     
Files Coverage Δ
...ource-detector-aws/src/detectors/AwsEksDetector.ts 100.00% <100.00%> (+8.75%) ⬆️
...metry-resource-detector-aws/src/detectors/index.ts 100.00% <100.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.19% <ø> (-0.59%) ⬇️
...e-detector-aws/src/detectors/AwsEksDetectorSync.ts 91.46% <91.46%> (ø)

... and 67 files with indirect coverage changes