Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@opentelemetry/instrumentation-winston): Add extra details about @opentelemetry/winston-transport scenarios #2302

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

hectorhdzg
Copy link
Member

Which problem is this PR solving?

Fixes #2283

Short description of the changes

Adding extra documentation about scenarios where both winston transport is added and winston instrumentation log sending is enabled.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (dfb2dff) to head (ae04ea9).
Report is 180 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2302      +/-   ##
==========================================
- Coverage   90.97%   90.42%   -0.56%     
==========================================
  Files         146      148       +2     
  Lines        7492     7322     -170     
  Branches     1502     1518      +16     
==========================================
- Hits         6816     6621     -195     
- Misses        676      701      +25     

see 62 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@trentm trentm enabled auto-merge (squash) June 28, 2024 23:25
@trentm trentm merged commit 85ca5f1 into open-telemetry:main Jun 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[instrumentation-winston] May duplicate transport (and logs) without notice
4 participants