chore: add script to update '@opentelemetry/*' deps in this repo #1992
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
- Coverage 90.97% 90.88% -0.10%
==========================================
Files 146 143 -3
Lines 7492 7402 -90
Branches 1502 1480 -22
==========================================
- Hits 6816 6727 -89
+ Misses 676 675 -1 |
| // (see "... requires running npm install twice ...") in some cases this | ||
| // 'npm install' doesn't actually install the new version, but do not | ||
| // error out! | ||
| // TODO: guard against this with 'npm ls' or package.json check? |
There was a problem hiding this comment.
I think that's a good idea. Though we'll likely not run into it anymore now that we've moved the pacakge that caused this to the incubator directory, we may have forgotten about it if happens again.
Can be done in a follow-up though. 🙂
There was a problem hiding this comment.
Though we'll likely not run into it anymore now that we've moved the pacakge that caused this to the incubator directory,
Unfortunately I think the weird case can still come up. David hit it recently in TAV tests with interplay between the 'mongodb' version being tested for TAV tests in instrumentation-mongodb and the pinned version of mongodb as a transitive dep of instrumentation-mongoose. See #2001 (comment)
Yuck.
There was a problem hiding this comment.
Do you prefer to have an issue created that might languish? or just leave the TODO in-place?
There was a problem hiding this comment.
Let's just leave the TODO in place. 👍
|
Testing: I've run the script a couple times after the above updates and it still seems to work correctly. |
Refs: #1917
This is a replacement for my earlier PR #1974 where I had mistakenly created a PR from the main branch of my fork. This corrects that to use a feature branch. Sorry for that shuffle.