fix: Fix Azure Fns Detector When Running with App Service Detector #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as app service when they're using functions and both detectors are imported.
JacksonWeber
changed the title
JacksonWeber
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 144 145 +1
Lines 7406 7410 +4
Branches 1483 1483
=======================================
+ Hits 6773 6777 +4
Misses 633 633
|
trentm
reviewed
Jan 3, 2024
...ors/node/opentelemetry-resource-detector-azure/test/detectors/AzureFunctionsDetector.test.ts
Outdated
Show resolved
Hide resolved
trentm
approved these changes
Jan 4, 2024
dyladan
approved these changes
Jan 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When running inside of an Azure Function and in the case where both the Azure Functions and Azure App Services detector were being run in the same application, because the Azure App Service check was not exclusive of the Azure Functions check, the application would incorrectly be identified as running inside of Azure App Services.
This PR also adds tests for both Azure Functions and Azure App Services detectors to ensure that they function as expected when running in the same application.