Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce number of mongoose versions (TAV) tested from 204 to 19 #1861

Merged

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Dec 12, 2023

This tests just the latest in each minor version.

Refs: #1860

This tests just the latest in each minor version.

Refs: open-telemetry#1860
@trentm trentm self-assigned this Dec 12, 2023
@trentm trentm requested a review from a team December 12, 2023 01:00
@github-actions github-actions bot requested a review from blumamir December 12, 2023 01:01
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just testing the latest in each minor version is a reasonable approach. Maybe we should add that to the CONTRIBUTING.md or GUIDELINES.md? 🤔

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #1861 (9b0ac0f) into main (63520b1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1861   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         144      144           
  Lines        7406     7406           
  Branches     1483     1483           
=======================================
  Hits         6773     6773           
  Misses        633      633           

@pichlermarc pichlermarc merged commit 7d110d5 into open-telemetry:main Dec 14, 2023
16 checks passed
@trentm trentm deleted the tm-tav-reduce-mongoose-versions branch December 14, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants