Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(user-interaction): update docs to include examples of config options #1840

Merged
merged 7 commits into from
Dec 4, 2023
Merged

docs(user-interaction): update docs to include examples of config options #1840

merged 7 commits into from
Dec 4, 2023

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Dec 1, 2023 •
edited
Loading

Which problem is this PR solving?

Documents config options for this instrumentation.

Closes #1770

Short description of the changes

  • Add README docs for eventNames option
  • Add README docs for shouldPreventSpanCreation option

@pkanal pkanal marked this pull request as ready for review December 1, 2023 16:43
@pkanal pkanal requested a review from a team December 1, 2023 16:43
@pkanal pkanal added documentation Improvements or additions to documentation pkg:instrumentation-user-interaction labels Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #1840 (5c01c15) into main (fb80783) will not change coverage.
The diff coverage is n/a.

❗ Current head 5c01c15 differs from pull request most recent head 05eb167. Consider uploading reports for the commit 05eb167 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1840   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         144      144           
  Lines        7388     7388           
  Branches     1474     1474           
=======================================
  Hits         6760     6760           
  Misses        628      628

@pkanal pkanal requested a review from martinkuba December 1, 2023 18:56
@pkanal pkanal merged commit 1c24cfd into open-telemetry:main Dec 4, 2023
13 checks passed
@pkanal pkanal deleted the docs/user-interaction-instrumentation branch December 4, 2023 16:19
@pichlermarc pichlermarc mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkuba martinkuba martinkuba approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation pkg:instrumentation-user-interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to add custom span attributes on user interaction traces
2 participants
@pkanal @martinkuba