-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix TAV tests for @cucumber/cucumber and @aws-sdk/client-s3 #1838
test: fix TAV tests for @cucumber/cucumber and @aws-sdk/client-s3 #1838
Conversation
- Switch to 'npm run --ws test-all-versions ...' for running TAV tests, instead of 'lerna run test-all-versions ...' because nx sets 'npm_config_legacy_peer_deps=true' which breaks '@cucumber/[email protected]' install and could break other installs by ignoring 'peerDependencies'. - Skip the bad '@aws-sdk/[email protected]' release in TAV tests. Also: - Reduce the number of versions of 'aws-sdk' and '@aws-sdk/*' packages test in TAV tests from 249, 143, and 132 versions currently, to 7 each. - Add a top-level `npm run test-all-versions` script to run that script in all packages that have one. This is the equivalent of the "test-all-versions.yml" CI workflow. Fixes: open-telemetry#1828
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
==========================================
+ Coverage 91.45% 91.49% +0.04%
==========================================
Files 144 144
Lines 7406 7388 -18
Branches 1483 1474 -9
==========================================
- Hits 6773 6760 -13
+ Misses 633 628 -5 |
Note to reviewers: The TAV tests failed, but for a different reason, so I think the PR is good to go.
the client-sqs failure
While we have #1477 already for client-sqs TAV test failures... this failure is actually a different failure reason than the one currently being discussed there. I can update that issue (or create a separate one). It would help if this PR went in, because the .tav.yml change means we are testing fewer versions of |
…ient-sqs versions using the AWS JSON 1.0 protocol Versions 3.446.0 and later switched to a new JSON protocol. https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md#34460-2023-11-08 Refs: open-telemetry#1838 (comment)
…ient-sqs versions using the AWS JSON 1.0 protocol (#1844) Versions 3.446.0 and later switched to a new JSON protocol. https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md#34460-2023-11-08 Refs: #1838 (comment)
…ient-sqs versions using the AWS JSON 1.0 protocol (open-telemetry#1844) Versions 3.446.0 and later switched to a new JSON protocol. https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md#34460-2023-11-08 Refs: open-telemetry#1838 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for taking care of this 🙂
instead of 'lerna run test-all-versions ...' because nx sets
'npm_config_legacy_peer_deps=true' which breaks
'@cucumber/[email protected]' install and could break other installs by
ignoring 'peerDependencies'.
Also:
test in TAV tests from 249, 143, and 132 versions currently, to 7
each.
npm run test-all-versions
script to run that scriptin all packages that have one. This is the equivalent of the
"test-all-versions.yml" CI workflow.
Fixes: #1828
Update for reviewers: See #1838 (comment) below for why I think this PR should go in, even though TAV tests are still failing.