fix: use context API to bind connection checkOut callback #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
==========================================
- Coverage 91.47% 91.47% -0.01%
==========================================
Files 143 143
Lines 7283 7282 -1
Branches 1458 1458
==========================================
- Hits 6662 6661 -1
Misses 621 621
|
Flarna
approved these changes
Nov 2, 2023
trentm
approved these changes
Nov 2, 2023
blumamir
approved these changes
Nov 7, 2023
Merged
david-luna
deleted the
dluna/1759-mongodb-instrumentation-context-bind
branch
6 tasks
jmcdo29
pushed a commit
to jmcdo29/opentelemetry-js-contrib
that referenced
this pull request
Nov 13, 2023
…etry#1766) * fix: use context API to bind connection checkOut callback * chore: fix lint --------- Co-authored-by: Amir Blum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
mongodbinstrumentation was usingAsynResource.bindAPI which has different behaviour in different node versions. This leads to the instrumentation breakingmongodbdriver for node v14Short description of the changes
context.bindfrom@opentelemetry/apiwhich is not affected by different node versions and is the recommended way to do it (thanks for the tip @Flarna)Closes: #1759