-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-mongodb): add support for mongodb v6 #1760
feat(instrumentation-mongodb): add support for mongodb v6 #1760
Conversation
plugins/node/opentelemetry-instrumentation-mongodb/package.json
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1760 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 144 144
Lines 7369 7369
Branches 1467 1467
=======================================
Hits 6743 6743
Misses 626 626
|
## Unreleased | ||
|
||
### Features | ||
|
||
* **mongodb:** support v6 ([#1666](https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1666)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog is automatically updated by the release automation. There is no need to do it here. It comes from the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed :)
Thanks @david-luna for taking this on. This is a big issue for us as our tracing is virtually useless without mongo spans and we're not about to downgrade to mongo v5. Just pinging @osherv here as well as they seem to be the owner on this component. |
@dyladan did a review. Maybe he could give the approval as well |
There's a version that uses https://node.green/#ES2021-features-Logical-Assignment-----basic-support @opentelemetry/instrumentation-mongodb: /home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-mongodb/node_modules/mongodb/node_modules/bson/lib/bson.cjs:479
@opentelemetry/instrumentation-mongodb: inspect ??= defaultInspect;
@opentelemetry/instrumentation-mongodb: ^^^
@opentelemetry/instrumentation-mongodb: SyntaxError: Unexpected token '??='
@opentelemetry/instrumentation-mongodb: at wrapSafe (internal/modules/cjs/loader.js:1029:16)
@opentelemetry/instrumentation-mongodb: at Module._compile (internal/modules/cjs/loader.js:1078:27)
@opentelemetry/instrumentation-mongodb: at Module.replacementCompile (/home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/node_modules/append-transform/index.js:60:13) |
@dyladan If you could take another look that would great 🙏 We're really looking forward to this change. |
Which problem is this PR solving?
mongodb
v6.Short description of the changes
6.*
in the necessary instrumentation modules.tav.yml
to add 6.x verisonsCHANGELOG.md
README.md
Closes: #1666