fix: span emit warnings on express instrumentation (#1891)

Fixes Can not execute the operation on ended Span on express-instrumentation #1887 This checks if the span has ended before attemptuing to mutate it by calling span.recordException(...) and span.setStatus(...) Signed-off-by: San 'rdn' Mônico <[email protected]> Co-authored-by: Jamie Danielson <[email protected]>
open-telemetry · Jan 18, 2024 · f65f2f1 · f65f2f1
1 parent 3156c94
commit f65f2f1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts
@@ -280,7 +280,7 @@ export class ExpressInstrumentation extends InstrumentationBase<
             const isError = ![undefined, null, 'route', 'router'].includes(
               maybeError
             );
-            if (isError) {
+            if (!spanHasEnded && isError) {
               const [error, message] = asErrorAndMessage(maybeError);
               span.recordException(error);
               span.setStatus({