Skip to content

Commit

Permalink
Update README
Browse files Browse the repository at this point in the history
  • Loading branch information
drewcorlin1 committed Jan 3, 2024
1 parent 8ae5b81 commit dee45d9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/esbuild-plugin-node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ for builtins or add any additional instrumentations.

### Gotchas

There are limitations to the configuration options for each package. Most notably, any functions (like `ignoreIncomingRequestHook` in the example) must not depend on any scope outside the function itself, including but not limited to module level variables and imports.
There are limitations to the configuration options for each package. Most notably, any functions (like `ignoreIncomingRequestHook` in the example) are not allowed to be passed in to plugins.

The reason for this is that the current mechanism of instrumenting packages involves stringifying the instrumentation configs, which does not account for any external scoped dependencies.
The reason for this is that the current mechanism of instrumenting packages involves stringifying the instrumentation configs, which does not account for any external scoped dependencies, and thus creates subtle opportunities for bugs.

```javascript
const {
Expand Down

0 comments on commit dee45d9

Please sign in to comment.