fix(eslint-no-floating-promises): added no-floating-promises rule (#1488

) Co-authored-by: Haddas Bronfman <[email protected]>
open-telemetry · May 9, 2023 · 4eb405e · 4eb405e
1 parent 1f6299d
commit 4eb405e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -29,6 +29,7 @@ module.exports = {
     {
       files: ['*.ts'],
       rules: {
+        "@typescript-eslint/no-floating-promises": "error",
         "@typescript-eslint/no-this-alias": "off",
         "@typescript-eslint/naming-convention": [
           "error",

diff --git a/plugins/node/opentelemetry-instrumentation-graphql/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-graphql/src/instrumentation.ts
@@ -253,13 +253,18 @@ export class GraphQLInstrumentation extends InstrumentationBase {
     }
 
     if (isPromise(result)) {
-      (result as Promise<graphqlTypes.ExecutionResult>).then(resultData => {
-        if (typeof config.responseHook !== 'function') {
-          endSpan(span);
-          return;
+      (result as Promise<graphqlTypes.ExecutionResult>).then(
+        resultData => {
+          if (typeof config.responseHook !== 'function') {
+            endSpan(span);
+            return;
+          }
+          this._executeResponseHook(span, resultData);
+        },
+        error => {
+          endSpan(span, error);
         }
-        this._executeResponseHook(span, resultData);
-      });
+      );
     } else {
       if (typeof config.responseHook !== 'function') {
         endSpan(span);