Skip to content

Commit

Permalink
fix: check existence of functions on prototype instead
Browse files Browse the repository at this point in the history
  • Loading branch information
pichlermarc committed Dec 4, 2024
1 parent 225289d commit 2968836
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ export function getConnectionPrototypeToInstrument(connection: any) {

// [email protected] included a refactoring, where most code was moved out of the `Connection` class and into a shared base
// so we need to instrument that instead, see https://github.com/sidorares/node-mysql2/pull/3081
if (basePrototype?.constructor?.name === 'BaseConnection') {
// This checks if the functions we're instrumenting are there on the base - we cannot use the presence of a base
// prototype since EventEmitter is the base for mysql2@<=3.11.4
if (typeof basePrototype?.query === 'function' && typeof basePrototype?.execute === 'function') {
return basePrototype;
}

Expand Down

0 comments on commit 2968836

Please sign in to comment.