Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to required PR checks #1659

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

trask
Copy link
Member

@trask trask commented Jan 20, 2025

I was surprised to find a PR that allowed me to merge even though a (sporadic) test was failing

@trask trask requested a review from a team as a code owner January 20, 2025 02:43
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, how were we getting away with this not included before? Was it a temporary thing or just a long-term oversight? Weird.

@breedx-splk breedx-splk merged commit 808b769 into open-telemetry:main Jan 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants