Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move the changelog guard #6100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 19, 2024

Something missed in the last release.

Something missed in the last release.
@MrAlias MrAlias added the Unlock Released Changelog PRs that need to change released section in CHANGELOG.md label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.2%. Comparing base (c862d2d) to head (216aa54).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6100   +/-   ##
=====================================
  Coverage   82.2%   82.2%           
=====================================
  Files        273     273           
  Lines      23674   23674           
=====================================
  Hits       19476   19476           
  Misses      3851    3851           
  Partials     347     347           

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can apply the Unlock Released Changelog label directly to the PR of adding missing stuff. Not sure this PR is needed.

@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 19, 2024

I think we can apply the Unlock Released Changelog label directly to the PR of adding missing stuff. Not sure this PR is needed.

I don't follow. Without that label the CI will fail. How can we move this?

@XSAM
Copy link
Member

XSAM commented Dec 19, 2024

I think we can apply the Unlock Released Changelog label directly to the PR of adding missing stuff. Not sure this PR is needed.

I don't follow. Without that label the CI will fail. How can we move this?

Since this PR didn't add anything that was missing from the last release, I assume there will be a following PR after this that will make the actual change. We can apply the label in the following PR that changes the content of the last release directly. So, moving the changelog guard seems unnecessary.

@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 19, 2024

Without this change a user can add an entry to the last release without our CI failing. I thought that was the purpose of the guard, right? Why are we not moving so that doesn't happen?

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad 🤦 I misread the color in the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unlock Released Changelog PRs that need to change released section in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants