-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Move the changelog guard #6100
base: main
Are you sure you want to change the base?
Conversation
Something missed in the last release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can apply the Unlock Released Changelog
label directly to the PR of adding missing stuff. Not sure this PR is needed.
I don't follow. Without that label the CI will fail. How can we move this? |
Since this PR didn't add anything that was missing from the last release, I assume there will be a following PR after this that will make the actual change. We can apply the label in the following PR that changes the content of the last release directly. So, moving the changelog guard seems unnecessary. |
Without this change a user can add an entry to the last release without our CI failing. I thought that was the purpose of the guard, right? Why are we not moving so that doesn't happen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad 🤦 I misread the color in the changes.
Something missed in the last release.