-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the otelhttp semconv tests to use metricdatatest #6400
Switch the otelhttp semconv tests to use metricdatatest #6400
Conversation
d864447
to
baf05ea
Compare
This PR may look big based on its diff size, but it's mostly just moving files into a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6400 +/- ##
=====================================
Coverage 67.8% 67.8%
=====================================
Files 200 200
Lines 16589 16589
=====================================
Hits 11254 11254
Misses 4993 4993
Partials 342 342
|
Ping @open-telemetry/go-approvers for review. |
This switches the otelhttp semconv tests to use the metricdatatest package rather than a custom struct with a partial metrics implementation.
This is meant to make it easier to start implementing the client and server metrics.