Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otellogr: Implement LevelSeverity, Enabled #6206

Merged
merged 10 commits into from
Oct 28, 2024
Merged

otellogr: Implement LevelSeverity, Enabled #6206

merged 10 commits into from
Oct 28, 2024

Conversation

scorpionknifes
Copy link
Member

This PR implements a few methods for otellogr package

  • Configurable LevelSeverity
  • Enabled

Please add skip changelog thx 🙏

Part of #5192

@scorpionknifes scorpionknifes requested review from pellared and a team as code owners October 5, 2024 12:50
@codecov Codecov
Copy link

codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.7%. Comparing base (f3c51a1) to head (b171aad).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6206   +/-   ##
=====================================
  Coverage   66.6%   66.7%           
=====================================
  Files        192     192           
  Lines      15535   15552   +17     
=====================================
+ Hits       10361   10381   +20     
+ Misses      4883    4881    -2     
+ Partials     291     290    -1
Files with missing lines Coverage Δ
bridges/otellogr/logsink.go 98.1% <100.0%> (+0.3%) ⬆️

... and 1 file with indirect coverage changes

@scorpionknifes scorpionknifes changed the title otellogr: Implement LevelSeverity otellogr: Implement LevelSeverity, Enabled Oct 5, 2024
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 7, 2024
pellared
pellared requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The higher V level - the less important (more verbose) logs are emitted

bridges/otellogr/logsink.go Outdated Show resolved Hide resolved
@pellared pellared added bridge: logr Related to the logr bridge enhancement New feature or request labels Oct 16, 2024
@pellared
Copy link
Member

@dmathieu, PTAL

@pellared pellared requested a review from dmathieu October 28, 2024 10:06
@pellared pellared merged commit 1379d74 into open-telemetry:main Oct 28, 2024
25 checks passed
@pellared pellared added this to the v1.32.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
bridge: logr Related to the logr bridge enhancement New feature or request Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@scorpionknifes @pellared @dmathieu