Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore commit upgrades for otel-go in renovate #6144

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

dmathieu
Copy link
Member

We often have unstable packages relying on a commit of otel-go temporarily, to spee up development.
That gives us very frequent renovate PRs (for every commit in otel-go), that we don't really need.

See #6142

This PR proposes to get renovate to only upgrade otel-go for releases matching semantic versions, so we don't upgrade every commit anymore.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.8%. Comparing base (bace98b) to head (eb95616).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6144   +/-   ##
=====================================
  Coverage   66.8%   66.8%           
=====================================
  Files        206     206           
  Lines      13211   13211           
=====================================
  Hits        8833    8833           
  Misses      4111    4111           
  Partials     267     267           

@dmathieu dmathieu marked this pull request as ready for review September 23, 2024 13:27
@dmathieu dmathieu requested a review from a team as a code owner September 23, 2024 13:27
renovate.json Outdated Show resolved Hide resolved
@pellared
Copy link
Member

@open-telemetry/go-approvers PTAL

@dmathieu dmathieu merged commit 0f2d426 into open-telemetry:main Oct 2, 2024
21 of 22 checks passed
@dmathieu dmathieu deleted the renovabot-otel-commits branch October 2, 2024 13:58
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants