Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable error-is-as rule from testifylint #6141

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Testifylint is a linter that provides best practices with the use of testify.

This PR enables error-is-as rule from testifylint

@mmorel-35 mmorel-35 requested review from MadVikingGod and a team as code owners September 22, 2024 20:13
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.5%. Comparing base (ba09b97) to head (98148bc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6141   +/-   ##
=====================================
  Coverage   66.4%   66.5%           
=====================================
  Files        205     205           
  Lines      13093   13093           
=====================================
+ Hits        8706    8708    +2     
+ Misses      4119    4118    -1     
+ Partials     268     267    -1     

see 1 file with indirect coverage changes

@pellared pellared merged commit c4e8bb3 into open-telemetry:main Sep 24, 2024
25 checks passed
@mmorel-35 mmorel-35 deleted the testifylint/error-is-as branch September 24, 2024 17:33
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants