[chore]: enable len and empty rules from testifylint #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
MrAlias,
a team,
dashpole,
MadVikingGod,
dmathieu and
hanyuancheung
as code owners
dmathieu
reviewed
Sep 19, 2024
mmorel-35
force-pushed
the
testifylint/bool-compare
branch
from
f92cac4 to
0664af5
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifylint/bool-compare
branch
from
0664af5 to
6795086
Compare
dmathieu
approved these changes
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6125 +/- ##
=====================================
Coverage 66.4% 66.4%
=====================================
Files 205 205
Lines 13093 13093
=====================================
Hits 8706 8706
Misses 4119 4119
Partials 268 268 |
pellared
approved these changes
Sep 19, 2024
MrAlias
approved these changes
Sep 19, 2024
dmathieu
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables empty and len rules from testifylint
It's linter provided by golangci-lint.
Here all available rules are activated except those who require to be fixed. This PR only fixes empty and len so the quantity of changes stays reasonnable for reviewers.