Logging bridge for logr

[scorpionknifes]

Towards #5192

Looking to do benchmarks in a different PR

Notes:

• slogSink converts any non string value to slog.Any which is handled with fmt.Sprintf("%+v", v) by otelslog. This PR does not do the above and instead opts to use convertValue to get the convert based on type which maybe less performant 🤔
• convertValue - follows how funcr handle interface{}
• currently it's designed to convert nested values recursively with convertValue, is there a max depth for converted attributes?
• kvBuffer - is used in otelslog, I propose to move kvBuffer to internal pkg and reused it here too?

[codecov]

Codecov Report

Attention: Patch coverage is 99.45055% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.8%. Comparing base (b058429) to head (beae842).
Report is 350 commits behind head on main.

Files with missing lines	Patch %	Lines
bridges/otellogr/logsink.go	99.4%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #5357     +/-   ##
=======================================
+ Coverage   65.3%   65.8%   +0.4%     
=======================================
  Files        203     204      +1     
  Lines      12780   12962    +182     
=======================================
+ Hits        8348    8529    +181     
- Misses      4189    4190      +1     
  Partials     243     243             

Files with missing lines	Coverage Δ
bridges/otellogr/logsink.go	99.4% <99.4%> (ø)

[pellared]

I made a quick review.

[dmathieu]

Suggested change

record.SetTimestamp(time.Now())

As in #5918 (comment)
The API implementation will set the timestamp to time.Now() already. So we can rely on that default.

[pellared]

Maybe we should respect the following conventions https://pkg.go.dev/github.com/go-logr/logr#hdr-Key_Naming_Conventions?

"level": the log level
"logger": the name of the associated logger
"ts": the timestamp for a log line

Better as a separate PR.

[dmathieu]

@scorpionknifes After chatting with @pellared we think it would be easier for us to review this PR if you split it into smaller ones, like we did for zap and zerolog.

If you want an example, you can look at the various

• otelzap PRs: https://github.com/open-telemetry/opentelemetry-go-contrib/pulls?q=is%3Apr+is%3Aclosed+otelzap+
• otelzerolog PRs: https://github.com/open-telemetry/opentelemetry-go-contrib/pulls?q=is%3Apr+author%3AAkhigbeEromo+is%3Aclosed+zerolog

[pellared]

Changing this PR to draft per #5357 (comment).

Use this PR as a reference for new PRs.

[pellared]

@scorpionknifes, are you able to follow up with creating smaller PRs or can we use your PR to start creating them ourselves (we can still add you as code owner)?

[scorpionknifes]

I apologize for being slow on this. I’ll look at it over the weekend. I’ll keep you posted! Thanks for your patience