Add unit tests for host instrumentation #3517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3517 +/- ##
=======================================
+ Coverage 69.9% 71.9% +1.9%
=======================================
Files 147 147
Lines 6934 6934
=======================================
+ Hits 4851 4988 +137
+ Misses 1959 1807 -152
- Partials 124 139 +15
|
Signed-off-by: Peter Liu <[email protected]>
Signed-off-by: Peter Liu <[email protected]>
Petrie
force-pushed
the
host-instrumentation-test
branch
from
86beff1 to
f100d6f
Compare
|
Adding tests shouldn't need a changelog entry. |
|
Signed-off-by: Peter Liu <[email protected]>
MrAlias
added
the
Skip Changelog
MrAlias
reviewed
Mar 2, 2023
pellared
reviewed
Mar 9, 2023
Comment on lines
+123
to
+130
| require.LessOrEqual(t, processBefore.User, processUser) | ||
| require.GreaterOrEqual(t, processAfter.User, processUser) | ||
| // System times are in range | ||
| require.LessOrEqual(t, processBefore.System, processSystem) | ||
| require.GreaterOrEqual(t, processAfter.System, processSystem) | ||
| // Ranges are not empty | ||
| require.NotEqual(t, processAfter.System, processBefore.System) | ||
| require.NotEqual(t, processAfter.User, processBefore.User) |
There was a problem hiding this comment.
In this block we could use assert. here instead of require..
Comment on lines
+140
to
+147
| require.LessOrEqual(t, hostBefore[0].User, systemUser) | ||
| require.GreaterOrEqual(t, hostAfter[0].User, systemUser) | ||
| // System times are in range | ||
| require.LessOrEqual(t, hostBefore[0].System, systemSystem) | ||
| require.GreaterOrEqual(t, hostAfter[0].System, systemSystem) | ||
| // Ranges are not empty | ||
| require.NotEqual(t, hostAfter[0].System, hostBefore[0].System) | ||
| require.NotEqual(t, hostAfter[0].User, hostBefore[0].User) |
There was a problem hiding this comment.
In this block we could use assert. here instead of require..
|
@Petrie, are you still willing to work on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2755