Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration testing to the host instrumenation #2755

Open
MrAlias opened this issue Sep 16, 2022 · 4 comments · May be fixed by #3517
Open

Add integration testing to the host instrumenation #2755

MrAlias opened this issue Sep 16, 2022 · 4 comments · May be fixed by #3517
Assignees
@Petrie
Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation: host

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 16, 2022

Integration testing for the host instrumentation was removed in #2754

When open-telemetry/opentelemetry-go#3031 is resolved, a new host/test package need to be created and integration testing for the instrumentation added to it.
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Sep 16, 2022
@MrAlias MrAlias removed this from the Metric SDK: Beta milestone Oct 28, 2022
This was referenced Oct 28, 2022
Closed
Closed
@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 28, 2022

Blocked by open-telemetry/opentelemetry-go#3407

@MrAlias MrAlias moved this to Blocked in Go: Metric SDK (Beta) Oct 28, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 31, 2022

Unblocked. Use a manual-reader to collect expected metrics and the metricdatatest package to compare expected values (or just compare directly).

@MrAlias MrAlias moved this from Blocked to Todo in Go: Metric SDK (Beta) Oct 31, 2022
@MrAlias MrAlias moved this to Backlog in Go: Metric SDK (Post-GA) Nov 4, 2022
@Petrie
Copy link
Contributor

Petrie commented Feb 17, 2023

hi @MrAlias , I would like to work on this issue, please assign it to me.

@Petrie Petrie linked a pull request Mar 1, 2023 that will close this issue
Open
@MrAlias MrAlias added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 18, 2024
@MrAlias MrAlias moved this from Needs Triage to TODO in Go: Metric SDK (Post-GA) Jan 18, 2024
@JAFFASH99
Copy link

hi mr alias . id like to work on this doc plz assign it to me also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Petrie Petrie

Labels
good first issue Good for newcomers help wanted Extra attention is needed instrumentation: host
Projects
Go: Metric SDK (Post-GA)
Status: TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit tests for host instrumentation Petrie/opentelemetry-go-contrib
3 participants
@Petrie @MrAlias @JAFFASH99