Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource #6046

Closed
wants to merge 2 commits into from
Closed

Add OpCode for activity started and stop in OpenTelemetry-Sdk eventsource #6046

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
259b53b
Add OpCode for activity started and stop in OpenTelemetry-Sdk eventso…
xiaomi7732 Jan 3, 2025
9981d61
Align the naming convention
xiaomi7732 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,13 @@ public void ObservableInstrumentCallbackException(string exception)
this.WriteEvent(16, exception);
}

[Event(24, Message = "Activity started. Name = '{0}', Id = '{1}'.", Level = EventLevel.Verbose)]
[Event(24, Message = "Activity started. Name = '{0}', Id = '{1}'.", Level = EventLevel.Verbose, Opcode = EventOpcode.Start)]
xiaomi7732 marked this conversation as resolved.
Show resolved Hide resolved
public void ActivityStarted(string name, string id)
{
this.WriteEvent(24, name, id);
}

[Event(25, Message = "Activity stopped. Name = '{0}', Id = '{1}'.", Level = EventLevel.Verbose)]
[Event(25, Message = "Activity stopped. Name = '{0}', Id = '{1}'.", Level = EventLevel.Verbose, Opcode = EventOpcode.Stop)]
public void ActivityStopped(string name, string? id)
{
this.WriteEvent(25, name, id);
Expand Down