-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Integration Test by Generating TLS/mTLS Certificates via MSBuild #5818
Conversation
0a6183e
to
4b43f25
Compare
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTest/.gitignore
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTest/create-cert.sh
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTest/create-cert.sh
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5818 +/- ##
==========================================
+ Coverage 83.38% 86.26% +2.88%
==========================================
Files 297 257 -40
Lines 12531 11252 -1279
==========================================
- Hits 10449 9707 -742
+ Misses 2082 1545 -537
Flags with carried forward coverage won't be shown. Click here to find out more. |
@reyang Hi! Fixed accordingly. |
@reyang Do you know what's the next step to get it merged, so that we can work on the remaining PRs to support mTLS? 🥹 |
|
...penTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTest/otel-collector-config.yaml
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTest/create-cert.sh
Outdated
Show resolved
Hide resolved
@sandy2008 try running the test locally. The CI does not pass. |
Sorry sorry, I forgot to push one change.. |
@alanwest Hmm, seems I need to give one fix, will fix it tmr. |
Hi! I am still on it. |
@alanwest Hi! Now should be fixed :)
|
Please help take a look & trigger the pipeline if you have time! Thank you so much! |
@Kielek Thank you for triggering the pipelines :) Is there a way that I can run the pipelines on my GitHub as well? |
@sandy2008, triggering pipeline by maintainers/approvers is only for first time contributors. All your following PRs will be executed automatically. |
Thank you! Would you mind triggering the pipeline again? |
Please help take a look & trigger the pipeline if you have time! Thank you so much! |
@alanwest Sorry.. Again please😭 Got a cert permission issue.. Now should be ok.. |
Thanks @sandy2008, looks like the CI is happy now. I will take another look at the PR tomorrow. |
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/gen_test_cert.ps1
Outdated
Show resolved
Hide resolved
...penTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTest/otel-collector-config.yaml
Show resolved
Hide resolved
Thank you so much for approving it :) @alanwest Do you know what's the next step to get it merged? |
merged! |
Fixes #2009
Based on PR #4731
Changes
This PR introduces an improvement in how integration tests handle TLS/mTLS certificates by generating them at build time via MSBuild. The generated certificates are stored in the build output directory.
Key Changes:
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changesLicense Information
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE LICENSE V.2.0. YOU MAY OBTAIN A COPY OF THE LICENSE AT https://github.com/open-telemetry/opentelemetry-python/blob/master/LICENSE.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.