[benchmarks] Add LogBenchmark when BatchProcessor is used #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Jul 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5746 +/- ##
==========================================
+ Coverage 83.38% 86.13% +2.75%
==========================================
Files 297 254 -43
Lines 12531 11057 -1474
==========================================
- Hits 10449 9524 -925
+ Misses 2082 1533 -549
Flags with carried forward coverage won't be shown. Click here to find out more. |
Kielek
approved these changes
Jul 15, 2024
Kielek
reviewed
Jul 15, 2024
Co-authored-by: Piotr Kiełkowicz <[email protected]>
reyang
reviewed
Jul 15, 2024
| @@ -134,7 +150,15 @@ public void ThreeProcessors() | |||
| this.loggerWithThreeProcessors.SayHello(FoodName, FoodPrice); | |||
| } | |||
|
|
|||
| internal class DummyLogProcessor : BaseProcessor<LogRecord> | |||
| internal class NoOpLogProcessor : BaseProcessor<LogRecord> | |||
There was a problem hiding this comment.
Suggested change
| internal class NoOpLogProcessor : BaseProcessor<LogRecord> | |
| internal class NoopLogProcessor : BaseProcessor<LogRecord> |
rajkumar-rangaraj
approved these changes
Jul 15, 2024
Co-authored-by: Reiley Yang <[email protected]>
cijothomas
commented
Jul 15, 2024
CodeBlanch
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Log Benchmark when
BatchExportProcessoris used instead of a normal NoOpProcessor. SDK special cases ourBatchExportProcessor(not 3rd party authored), to use a different LogRecord pooling mechanism.This benchmark will show the perf difference, when using that pooling mechanism. (It is much higher than the ThreadLocal based pooling, only useable in sync exporters like etw)
Also renamed Dummy -> NoOp processor, as the processor is a no-op, with no ability to accept alternate behavior.
The following shows the cost when BatchingProcessor is used (compared to other processor), which has to copy all the Log state+scope.
@CodeBlanch mentioned that the benchmarks is pushing large number of logs forcing the pool to hit the limit, and start allocating.