-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump System.Text.Json version due to CVE-2024-30105 #5744
Bump System.Text.Json version due to CVE-2024-30105 #5744
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5744 +/- ##
==========================================
+ Coverage 83.38% 86.19% +2.81%
==========================================
Files 297 254 -43
Lines 12531 11057 -1474
==========================================
- Hits 10449 9531 -918
+ Misses 2082 1526 -556
Flags with carried forward coverage won't be shown. Click here to find out more. |
FYI: dotnet/runtime#104619 (comment) |
Thanks @cremor 4.7.2 version is not vulnerable. I will change this PR to update the test and examples package. |
@alanwest Could you help merge this? Blanch is on vacation, and this is pre-req to unblock any other PRs. |
I am out today, but could be available to merge this. Will be near a computer soonish. I see build failed though... |
Prior failure was due to nuget/ci bug that incorrectly detected 4.7.2 as vulnerable. I re-triggerred CI, hopefully it should pass! |
CI is green now :) |
Discussion for this issue can be found at dotnet/runtime#104619
System.Text.Json
have been updated.System.Text.Json
, so no update is needed there.Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.md
files updated for non-trivial changesChanges in public API reviewed (if applicable)