Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo-shared] Remove the new() constraint from Options API helpers #5422

Merged

Conversation

CodeBlanch
Copy link
Member

[Originally part of #5400]

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Mar 7, 2024
@CodeBlanch CodeBlanch requested a review from a team March 7, 2024 21:36
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (6250307) to head (9b85a42).
Report is 117 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5422      +/-   ##
==========================================
+ Coverage   83.38%   84.34%   +0.95%     
==========================================
  Files         297      281      -16     
  Lines       12531    12082     -449     
==========================================
- Hits        10449    10190     -259     
+ Misses       2082     1892     -190     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.35% <ø> (?)
unittests-Instrumentation-Stable 24.38% <ø> (?)
unittests-Solution-Experimental 84.78% <ø> (?)
unittests-Solution-Stable 84.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 70 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit f34fce5 into open-telemetry:main Mar 7, 2024
49 checks passed
@CodeBlanch CodeBlanch deleted the shared-options-constraint branch March 7, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants