Reduce memory usage by reclaimed MetricPoint #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specialforest
force-pushed
the
recycle-memory-used-by-reclaimed-metricpoint
branch
from
4dd3bf5 to
57fec34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5416 +/- ##
==========================================
+ Coverage 83.38% 84.70% +1.32%
==========================================
Files 297 281 -16
Lines 12531 12105 -426
==========================================
- Hits 10449 10254 -195
+ Misses 2082 1851 -231
Flags with carried forward coverage won't be shown. Click here to find out more.
|
utpilla
approved these changes
Mar 6, 2024
cijothomas
reviewed
Mar 6, 2024
| internal void Reclaim() | ||
| { | ||
| this.LookupData = null; | ||
| this.mpComponents = null; |
|
@specialforest Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Current MetricPoint reclaim mechanism leaves lots of unused objects in memory (histogram buckets, exemplar). With this change these objects can be garbage collected.
Tested with a sample program:
Heap snapshot before the change:
Heap snapshot after the change:
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes