Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Pass all tags supplied at measurement to ExemplarReservoir.Offer methods #5414

Merged

Conversation

CodeBlanch
Copy link
Member

Changes

  • Pass all tags supplied at measurement to ExemplarReservoir.Offer methods to make the promise true.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Mar 5, 2024
@CodeBlanch CodeBlanch requested a review from a team March 5, 2024 23:19
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (6250307) to head (2131ca0).
Report is 114 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5414      +/-   ##
==========================================
+ Coverage   83.38%   84.71%   +1.32%     
==========================================
  Files         297      281      -16     
  Lines       12531    12101     -430     
==========================================
- Hits        10449    10251     -198     
+ Misses       2082     1850     -232     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 84.72% <100.00%> (?)
unittests-Solution-Stable 84.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 85.21% <100.00%> (+4.82%) ⬆️
src/OpenTelemetry/Metrics/Exemplar/Exemplar.cs 95.65% <100.00%> (-4.35%) ⬇️

... and 55 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit a7f3400 into open-telemetry:main Mar 6, 2024
37 checks passed
@CodeBlanch CodeBlanch deleted the sdk-metrics-exemplar-tag-fix branch March 6, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants