Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log filter example #5406

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

reyang
Copy link
Member

@reyang reyang commented Mar 2, 2024

  1. applied best practices
  2. updated the filter example to match with the guidance

@reyang reyang requested a review from a team March 2, 2024 04:23
@reyang reyang added the documentation Documentation related label Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (6250307) to head (7025be8).
Report is 113 commits behind head on main.

❗ Current head 7025be8 differs from pull request most recent head 861b961. Consider uploading reports for the commit 861b961 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5406      +/-   ##
==========================================
+ Coverage   83.38%   84.75%   +1.37%     
==========================================
  Files         297      281      -16     
  Lines       12531    12079     -452     
==========================================
- Hits        10449    10238     -211     
+ Misses       2082     1841     -241     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 84.66% <ø> (?)
unittests-Solution-Stable 84.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

@utpilla utpilla merged commit df2abe8 into open-telemetry:main Mar 5, 2024
30 checks passed
@reyang reyang deleted the reyang/log-filter-example branch March 6, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants