-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to ActivityCreation benchmarks #5173
Merged
utpilla
merged 7 commits into
open-telemetry:main
from
cijothomas:cijothomas/benchmark-activitycreation
Dec 14, 2023
Merged
Tweaks to ActivityCreation benchmarks #5173
utpilla
merged 7 commits into
open-telemetry:main
from
cijothomas:cijothomas/benchmark-activitycreation
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
reviewed
Dec 14, 2023
utpilla
reviewed
Dec 14, 2023
utpilla
reviewed
Dec 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5173 +/- ##
==========================================
- Coverage 83.43% 83.25% -0.19%
==========================================
Files 297 297
Lines 12366 12366
==========================================
- Hits 10318 10295 -23
- Misses 2048 2071 +23
Flags with carried forward coverage won't be shown. Click here to find out more. |
utpilla
reviewed
Dec 14, 2023
utpilla
reviewed
Dec 14, 2023
utpilla
reviewed
Dec 14, 2023
utpilla
reviewed
Dec 14, 2023
utpilla
reviewed
Dec 14, 2023
utpilla
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.2 Added a benchmark to compare the perf difference between using SetTag vs AddTag. The former does de-duplication+override, the latter does not do this. In scenarios where the tags are controlled (eg: Instrumentation Libraries from this repo), it might be faster to use AddTag instead of SetTag. This PR is simply adding benchmarks to help support that decision (in a future PR) for the instrumentations, and also give a recommendation to end users about the AddTag vs SetTag behavior.
Yes, SetTag is the spec-compliant API, but users who are in full control of their Tags might leverage AddTag to save some unwanted cpu cycles to detect duplicates. The cost increases with each attribute, as the current implementation traverses the list to look for duplicate.