Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from Http instrumentation #5159

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Dec 12, 2023

Changes

  • Remove unused code from Http instrumentation

@utpilla utpilla marked this pull request as ready for review December 12, 2023 18:47
@utpilla utpilla requested a review from a team December 12, 2023 18:47
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #5159 (c95f96e) into main (0278deb) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5159      +/-   ##
==========================================
+ Coverage   83.36%   83.44%   +0.07%     
==========================================
  Files         297      297              
  Lines       12388    12368      -20     
==========================================
- Hits        10327    10320       -7     
+ Misses       2061     2048      -13     
Flag Coverage Δ
unittests 83.44% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ation.Http/HttpRequestMessageContextPropagation.cs 100.00% <ø> (+64.28%) ⬆️
...strumentation.Http/Implementation/HttpTagHelper.cs 72.72% <ø> (+37.94%) ⬆️

... and 8 files with indirect coverage changes

@utpilla utpilla merged commit 486ee58 into open-telemetry:main Dec 12, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants