Add main readme for traces with best practices #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5144 +/- ##
==========================================
- Coverage 83.31% 83.31% -0.01%
==========================================
Files 297 297
Lines 12380 12380
==========================================
- Hits 10315 10314 -1
- Misses 2065 2066 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
utpilla
reviewed
Dec 8, 2023
utpilla
reviewed
Dec 8, 2023
utpilla
approved these changes
Dec 9, 2023
reyang
approved these changes
Dec 9, 2023
vishweshbankwar
approved these changes
Dec 9, 2023
Co-authored-by: Vishwesh Bankwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added similar doc for metrics already (https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/metrics), this PR is adding for traces. This is just the initial step, happy to iterate based on feedbacks.