-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fix for RecordException #5143
Merged
utpilla
merged 6 commits into
open-telemetry:main
from
cijothomas:cijothomas/activity-exception-doc-fix
Dec 8, 2023
Merged
Doc fix for RecordException #5143
utpilla
merged 6 commits into
open-telemetry:main
from
cijothomas:cijothomas/activity-exception-doc-fix
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5143 +/- ##
=======================================
Coverage 83.29% 83.29%
=======================================
Files 297 297
Lines 12380 12380
=======================================
Hits 10312 10312
Misses 2068 2068
Flags with carried forward coverage won't be shown. Click here to find out more.
|
utpilla
reviewed
Dec 7, 2023
utpilla
reviewed
Dec 7, 2023
vishweshbankwar
approved these changes
Dec 7, 2023
utpilla
reviewed
Dec 7, 2023
utpilla
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1569
Given we were using
ToString()
from the 1st stable release, documenting thatex.ToString()
is the chosen representation of stacktrace. #1569 has question about usingToString()
vsStackTrace
, but given this is already part of stable release, we need to keep this behavior.It is okay to provide an option to customize this, if there is demand, or change the chosen representation in v2.0. This PR is just documenting the existing behavior.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes