Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moq cleanup #5133

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Moq cleanup #5133

merged 1 commit into from
Dec 6, 2023

Conversation

ngruson
Copy link
Contributor

@ngruson ngruson commented Dec 6, 2023

Fixes #4758
Removed the last remnants of Moq

Changes

  • Removed Moq package from Directory.Packages.props
  • Removed Moq public key from AssemblyInfo.cs

@ngruson ngruson requested a review from a team December 6, 2023 06:52
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #5133 (0064629) into main (a963ec8) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5133      +/-   ##
==========================================
+ Coverage   83.06%   83.08%   +0.01%     
==========================================
  Files         296      296              
  Lines       12320    12320              
==========================================
+ Hits        10234    10236       +2     
+ Misses       2086     2084       -2     
Flag Coverage Δ
unittests 83.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@utpilla
Copy link
Contributor

utpilla commented Dec 6, 2023

Thanks for your help @ngruson!

@utpilla utpilla merged commit 4cf2bf4 into open-telemetry:main Dec 6, 2023
39 checks passed
@ngruson ngruson deleted the moq-cleanup branch December 6, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider Moq usage because of privacy issues
4 participants