Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] dotnet format ci follow-up #5012

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

CodeBlanch
Copy link
Member

Follow-up to #4881

Changes

  • Run the dotnet format job in stable & experimental modes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch
Copy link
Member Author

@sharwell

Seems we are getting a lot of odd errors from dotnet format using .NET 8 RC2: https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/6725194812/job/18279064981?pr=5012#step:5:9

I tried to get it working locally but I can't seem to figure it out. Is this a known thing?

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #5012 (f9ae5f4) into main (ba161c4) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5012      +/-   ##
==========================================
- Coverage   83.51%   83.40%   -0.12%     
==========================================
  Files         296      296              
  Lines       12377    12377              
==========================================
- Hits        10337    10323      -14     
- Misses       2040     2054      +14     
Flag Coverage Δ
unittests 83.40% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...endencyInjectionLoggerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...encyInjectionLoggingServiceCollectionExtensions.cs 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

@CodeBlanch CodeBlanch marked this pull request as ready for review November 1, 2023 22:08
@CodeBlanch CodeBlanch requested a review from a team November 1, 2023 22:08
@CodeBlanch CodeBlanch merged commit c8f939e into open-telemetry:main Nov 2, 2023
35 checks passed
@CodeBlanch CodeBlanch deleted the dotnet-format-followup branch November 2, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants